Patch PRECIOUS and echo #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice utility. Here's a minor fix. # Incorrect behavior, deleting intermediate .dephash files > make Updating hash file: .dephash/a1.dephash cp a1 b1 rm .dephash/a1.dephash # Correct behavior, keeping intermediate .dephash files > make Updating hash file: .dephash/a1.dephash cp a1 b1 > cat Makefile HASHDEPS_HASH_TREE_DIR := .dephash -include hashdeps/hashdeps.mk .DEFAULT_GOAL := b1 b%: $(call hash_deps,a%) cp $(call unhash_deps,$<) $@ clean: -rm -rf b* .dephash
On macOS, echo -n in sh doesn't work as desired, but /bin/echo -n does. # Wrong output includes -n. Cf. https://pubs.opengroup.org/onlinepubs/009604599/utilities/echo.html prompt> echo -n foo -n foo prompt> # Correct output suppresses trailing newline prompt> /bin/echo -n foo fooprompt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice utility. This fixes 2 minor issues. See commits for details.