Implements dev commands for makefile #107
Conversation
douglasfarinelli
force-pushed
the
implements-dev-commands-for-makefile
branch
from
df071a9
to
a7a5640
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 11 11
Lines 1574 1574
=======================================
Hits 1558 1558
Misses 16 16Continue to review full report at Codecov.
|
|
@douglasfarinelli Thanks for your PR! We'll check it soon. 😄 |
requirements-test.txt
Outdated
| @@ -1,6 +1,8 @@ | |||
| -r requirements.txt | |||
| factory-boy==2.8.1 | |||
| mypy | |||
| isort==4.2.15 | |||
There was a problem hiding this comment.
Isn't isort a development dependency instead a test dependency?
There was a problem hiding this comment.
@cacarrara I really do not agree to be a test dependency either. I'm going to change.
There was a problem hiding this comment.
I moved flake8 and mypy too... 👍
douglasfarinelli
force-pushed
the
implements-dev-commands-for-makefile
branch
from
a7a5640
to
2ccd6db
Compare
requirements-dev.txt
Outdated
| @@ -1,2 +1,5 @@ | |||
| -r requirements-test.txt | |||
| bumpversion | |||
| isort==4.2.15 | |||
There was a problem hiding this comment.
IMO it's important to always have the latest version for these packages and the version pin is unnecessary. can you remove it?
There was a problem hiding this comment.
@lamenezes Yes, but I do not think it's a good idea, because for this release, isort works well with this release. I'll remove it!
douglasfarinelli
force-pushed
the
implements-dev-commands-for-makefile
branch
from
b717c88
to
09a4bbb
Compare
douglasfarinelli
force-pushed
the
implements-dev-commands-for-makefile
branch
from
09a4bbb
to
62f47a4
Compare
No description provided.