Make warrior upset when losing points #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 90.84% 90.87% +0.02%
==========================================
Files 80 80
Lines 1016 1019 +3
Branches 158 158
==========================================
+ Hits 923 926 +3
Misses 77 77
Partials 16 16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@skywalker212 Looks good, but it's missing a unit test. Would you mind adding it?
|
@olistic ya sure, but I don't know how to add a unit test, can you tell me how to add one? |
|
@skywalker212 Sure. In this particular case, it's super easy. Just look at the earning points test in |
|
@olistic I have added the unit test, please review. |
| warrior.losePoints(5); | ||
| expect(warrior.say).toHaveBeenCalledWith('loses 5 points'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@skywalker212 Linting is complaining because of this extra line break, you need to remove the empty line.
olistic
changed the title
|
@olistic I have made the changes, please review. |
|
@olistic Thanks for guiding through problems! |
Closes #104