Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed diamond symbol on windows CMD #121

Merged
merged 2 commits into from
May 18, 2018
Merged

Fixed diamond symbol on windows CMD #121

merged 2 commits into from
May 18, 2018

Conversation

glneto
Copy link
Contributor

@glneto glneto commented May 18, 2018

Hello!

This change should fix the diamond symbol on Windows' CMD.
I used the is-windows util to check the user env and in case that returns true, I use the Black Diamond Suit (as suggested on the issue), otherwise I keep the black medium diamond symbol.

I hope that helps.

Fixes #112

Copy link
Owner

@olistic olistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glneto! Thanks for the patch! I prefer not to add a dependency just for this. Let's always use the Black Diamond Suit character, independently of the platform.

@codecov-io
Copy link

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          80       80           
  Lines        1019     1019           
  Branches      158      158           
=======================================
  Hits          926      926           
  Misses         77       77           
  Partials       16       16
Impacted Files Coverage Δ
...ackages/warriorjs-cli/src/ui/printWarriorStatus.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1872e0c...530e2a8. Read the comment docs.

@glneto
Copy link
Contributor Author

glneto commented May 18, 2018

@olistic Alright! I didn't see the is-windows package wasn't being used. Should be good now :)

@olistic olistic merged commit 963c236 into olistic:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diamond character in score is broken on Windows CMD
3 participants