Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profile directory detection #133

Merged
merged 2 commits into from
May 19, 2018
Merged

Improve profile directory detection #133

merged 2 commits into from
May 19, 2018

Conversation

glneto
Copy link
Contributor

@glneto glneto commented May 19, 2018

Hello!
There were some problems while rebasing the previous branch.

This one follows the same approach, checking for the Player.js file as requested on the issue.

Tests are already written for the new function.

Hope it helps.

Closes #119

@codecov-io
Copy link

codecov-io commented May 19, 2018

Codecov Report

Merging #133 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage    90.9%   90.89%   -0.02%     
==========================================
  Files          80       80              
  Lines        1023     1032       +9     
  Branches      162      164       +2     
==========================================
+ Hits          930      938       +8     
- Misses         77       78       +1     
  Partials       16       16
Impacted Files Coverage Δ
packages/warriorjs-cli/src/Profile.js 96.19% <100%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d364e...fb478a6. Read the comment docs.

Copy link
Owner

@olistic olistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, @glneto! Thanks

@olistic olistic merged commit 8b55b8a into olistic:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants