Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit.release() method #140

Merged
merged 2 commits into from
May 19, 2018
Merged

Add unit.release() method #140

merged 2 commits into from
May 19, 2018

Conversation

olistic
Copy link
Owner

@olistic olistic commented May 19, 2018

Move release logic (unbinding and scoring) from the rescue ability to the core.

@codecov-io
Copy link

Codecov Report

Merging #140 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #140      +/-   ##
=========================================
+ Coverage   91.08%   91.1%   +0.01%     
=========================================
  Files          81      81              
  Lines        1043    1045       +2     
  Branches      167     167              
=========================================
+ Hits          950     952       +2     
  Misses         77      77              
  Partials       16      16
Impacted Files Coverage Δ
packages/warriorjs-abilities/src/rescue.js 100% <100%> (ø) ⬆️
packages/warriorjs-core/src/Unit.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f59ed...6086633. Read the comment docs.

@olistic olistic merged commit 351cdf4 into master May 19, 2018
@olistic olistic deleted the unit-release branch May 19, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants