Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warrior name suggestions #152

Merged
merged 3 commits into from
May 22, 2018
Merged

Add warrior name suggestions #152

merged 3 commits into from
May 22, 2018

Conversation

olistic
Copy link
Owner

@olistic olistic commented May 22, 2018

Closes #151

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #152 into master will increase coverage by 1.17%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   91.14%   92.32%   +1.17%     
==========================================
  Files          82       83       +1     
  Lines        1050     1055       +5     
  Branches      171      173       +2     
==========================================
+ Hits          957      974      +17     
+ Misses         77       66      -11     
+ Partials       16       15       -1
Impacted Files Coverage Δ
packages/warriorjs-cli/src/Game.js 53.16% <0%> (-0.34%) ⬇️
packages/warriorjs-cli/src/ui/requestChoice.js 90% <100%> (+70%) ⬆️
packages/warriorjs-cli/src/ui/requestInput.js 100% <100%> (+75%) ⬆️
...rriorjs-cli/src/utils/getWarriorNameSuggestions.js 100% <100%> (ø)
...ckages/warriorjs-cli/src/ui/requestConfirmation.js 100% <100%> (+75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32eb543...9466218. Read the comment docs.

@olistic olistic merged commit e0f75be into master May 22, 2018
@olistic olistic deleted the warrior-name-suggestions branch May 22, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants