Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGB color to units #165

Merged
merged 2 commits into from
Jul 7, 2018
Merged

Add RGB color to units #165

merged 2 commits into from
Jul 7, 2018

Conversation

olistic
Copy link
Owner

@olistic olistic commented May 27, 2018

Before:

before

^ Note how the Archer and the Captive had the same color due to the algorithm that was used to select colors for them automatically.

After:

after

(In the CLI, unit colors are downsampled from RGB to 256 color ANSI for greater uniformity.)

@codecov-io
Copy link

codecov-io commented May 27, 2018

Codecov Report

Merging #165 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files          86       86              
  Lines        1069     1068       -1     
  Branches      173      173              
==========================================
- Hits          986      985       -1     
  Misses         68       68              
  Partials       15       15
Impacted Files Coverage Δ
packages/warriorjs-units/src/Captive.js 100% <ø> (ø) ⬆️
packages/warriorjs-units/src/Archer.js 100% <ø> (ø) ⬆️
packages/warriorjs-units/src/Wizard.js 100% <ø> (ø) ⬆️
packages/warriorjs-units/src/ThickSludge.js 100% <ø> (ø) ⬆️
packages/warriorjs-units/src/Warrior.js 100% <ø> (ø) ⬆️
packages/warriorjs-units/src/Sludge.js 100% <ø> (ø) ⬆️
packages/warriorjs-core/src/loadLevel.js 89.28% <100%> (ø) ⬆️
packages/warriorjs-core/src/Warrior.js 100% <100%> (ø) ⬆️
packages/warriorjs-cli/src/ui/getUnitStyle.js 100% <100%> (ø) ⬆️
packages/warriorjs-core/src/Unit.js 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbccb2d...2c3f54e. Read the comment docs.

@olistic olistic force-pushed the unit-colors branch 2 times, most recently from 11f6657 to 5fdb748 Compare June 1, 2018 00:16
@olistic olistic force-pushed the unit-colors branch 2 times, most recently from 00676d6 to 44fa25f Compare July 7, 2018 00:18
@olistic olistic merged commit c24ff74 into master Jul 7, 2018
@olistic olistic deleted the unit-colors branch July 7, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants