Sort actions and senses alphabetically #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 86 86
Lines 1077 1077
Branches 180 180
=======================================
Hits 994 994
Misses 68 68
Partials 15 15Continue to review full report at Codecov.
|
| const actions = abilities.filter(ability => ability.action); | ||
| const senses = abilities.filter(ability => !ability.action); | ||
| const actions = abilities.filter(ability => ability.action).sort((a, b) => a.name > b.name); | ||
| const senses = abilities.filter(ability => !ability.action).sort((a, b) => a.name > b.name); |
There was a problem hiding this comment.
Can you refactor this, extracting the sort call and saving the result in a new variable?
There was a problem hiding this comment.
@olistic Sounds good, I was already thinking it might be better to do this just once, will pick this up today/tomorrow!
| @@ -1,17 +1,20 @@ | |||
| <%_ | |||
| const actions = abilities.filter(ability => ability.action); | |||
| const senses = abilities.filter(ability => !ability.action); | |||
|
|
|||
| const sortedActions = actions.sort((a, b) => a.name > b.name); | |||
| const sortedSenses = senses.sort((a, b) => a.name > b.name); | |||
There was a problem hiding this comment.
Hey @djohalo2, what I originally meant is that you can sort the entire array of abilities just once, and then filter it. The resulting code is much simpler:
const sortedAbilities = abilities.sort((a, b) => a.name > b.name);
const actions = sortedAbilities.filter(ability => ability.action);
const senses = sortedAbilities.filter(ability => !ability.action);
|
No problem, this looks better! |
Fixes #189