Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract helpers #215

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Extract helpers #215

merged 2 commits into from
Jul 15, 2018

Conversation

olistic
Copy link
Owner

@olistic olistic commented Jul 13, 2018

  • Extract getLevelConfig into its own package.
  • Extract scoring logic into helper packages.

@codecov-io
Copy link

codecov-io commented Jul 13, 2018

Codecov Report

Merging #215 into master will increase coverage by <.01%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   92.63%   92.64%   +<.01%     
==========================================
  Files          86       92       +6     
  Lines        1072     1087      +15     
  Branches      171      165       -6     
==========================================
+ Hits          993     1007      +14     
- Misses         64       65       +1     
  Partials       15       15
Impacted Files Coverage Δ
...iorjs-helper-get-play-score/src/getWarriorScore.js 100% <100%> (ø)
packages/warriorjs-cli/src/Profile.js 96.39% <100%> (-0.04%) ⬇️
...arriorjs-helper-get-play-score/src/isFloorClear.js 100% <100%> (ø)
packages/warriorjs-cli/src/ui/printLevelReport.js 100% <100%> (ø) ⬆️
...kages/warriorjs-helper-get-play-score/src/index.js 100% <100%> (ø)
...arriorjs-helper-get-play-score/src/getTurnCount.js 100% <100%> (ø)
packages/warriorjs-core/src/loadLevel.js 89.28% <100%> (ø) ⬆️
...ges/warriorjs-helper-get-level-config/src/index.js 100% <100%> (ø)
...orjs-helper-get-play-score/src/getGradeForScore.js 100% <100%> (ø)
packages/warriorjs-cli/src/ui/printTowerReport.js 100% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90795c...6f33182. Read the comment docs.

@olistic olistic merged commit 21cb227 into master Jul 15, 2018
@olistic olistic deleted the extract-helpers branch July 15, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants