Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix think ability #220

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix think ability #220

merged 2 commits into from
Jul 25, 2018

Conversation

olistic
Copy link
Owner

@olistic olistic commented Jul 25, 2018

Previously, warrior.think({ foo: 'bar' }) printed Spartacus thinks [object Object]. This PR fixes that, plus makes the behavior of warrior.think() almost the same as console.log().

@codecov-io
Copy link

Codecov Report

Merging #220 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   92.64%   92.64%   +<.01%     
==========================================
  Files          92       92              
  Lines        1087     1088       +1     
  Branches      165      165              
==========================================
+ Hits         1007     1008       +1     
  Misses         65       65              
  Partials       15       15
Impacted Files Coverage Δ
packages/warriorjs-abilities/src/think.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419a081...d91b426. Read the comment docs.

@olistic olistic merged commit 1561730 into master Jul 25, 2018
@olistic olistic deleted the fix-think-ability branch July 25, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants