Add maxHealth ability #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to towers baby-steps and tick-tick-boom
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 92.65% 92.67% +0.02%
==========================================
Files 92 93 +1
Lines 1089 1092 +3
Branches 165 165
==========================================
+ Hits 1009 1012 +3
Misses 65 65
Partials 15 15
Continue to review full report at Codecov.
|
|
Added maxHealth ability and included it in existing towers, updating the baby-steps tip to introduce it. Let me know if I missed anything! |
olistic
requested changes
Oct 6, 2018
| @@ -11,6 +11,7 @@ import { | |||
| attack, | |||
| feel, | |||
| health, | |||
| maxHealth, | |||
There was a problem hiding this comment.
nit: this should be in alphabetical order.
|
Thanks for the feedback! The code base was a pleasure to work with. Good catch, I'll push a fix shortly. |
olistic
approved these changes
Oct 6, 2018
|
Thanks, and welcome to the Contributors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to towers baby-steps and tick-tick-boom.
Closes #237.