Add warrior score next to health in play log #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 86.03% 86.06% +0.02%
==========================================
Files 80 80
Lines 1017 1019 +2
Branches 154 154
==========================================
+ Hits 875 877 +2
Misses 127 127
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -10,10 +10,15 @@ import printLine from './printLine'; | |||
| */ | |||
| function printWarriorStatus(warrior) { | |||
| const [screenWidth] = getScreenSize(); | |||
| const warriorStatus = chalk.red( | |||
| const warriorStatus = chalk.redBright( | |||
There was a problem hiding this comment.
nit: for the sake of correctness, we should rename this variable to warriorHealth.
| @@ -14,6 +14,17 @@ test('prints warrior health in red', () => { | |||
| }; | |||
| printWarriorStatus(warrior); | |||
| expect(printLine).toHaveBeenCalledWith( | |||
| `${style.red.open}♥ 20 ${style.red.close}`, | |||
| `${style.redBright.open}♥ 20 ${style.redBright.close}`, | |||
There was a problem hiding this comment.
super-nit: change red to bright red in the test's description as well.
Allows users to see how their score changes turn by turn. Change health color from red to bright red.
|
Sorry about my player dictionary accidentally being included, that's what I get for leaving it there. Good catch on the Before Changes:
Red and Bright Yellow:
Bright Red and Bright Yellow: (Current)
|
|
Thanks @RascalTwo! |
olistic
changed the title
Allows users to see how their score changes turn by turn.
Change health color from red to bright red.