Fix path normalization in tests #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running tests on a non-posix machine (eg. Windows) would cause several to fail. The cause of the failure was file path comparison. The expected values were written as posix style file paths (eg. a/b/c.txt) while the actual values were returning windows style file paths (eg. a\\b\\c.txt). The solution to this was to use node's built in path module to normalize the paths for each system (https://nodejs.org/api/path.html#path_path_normalize_path).
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 80 80
Lines 1019 1019
Branches 154 154
=======================================
Hits 877 877
Misses 127 127
Partials 15 15Continue to review full report at Codecov.
|
olistic
approved these changes
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running tests on a non-posix machine (eg. Windows) would
cause several to fail. The cause of the failure was file path comparison.
The expected values were written as posix style file paths (eg. a/b/c.txt)
while the actual values were returning windows style file paths (eg. a\b\c.txt).
The solution to this was to use node's built in path module to normalize
the paths for each system (https://nodejs.org/api/path.html#path_path_normalize_path).
closes #76