Rescue ability awarts unit's reward #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
- Coverage 90.41% 90.4% -0.01%
=========================================
Files 80 80
Lines 1012 1011 -1
Branches 154 154
=========================================
- Hits 915 914 -1
Misses 82 82
Partials 15 15
Continue to review full report at Codecov.
|
olistic
reviewed
May 13, 2018
There was a problem hiding this comment.
Thanks @RascalTwo! The changes look good. I just have one suggestion regarding the ability's description.
| @@ -25,8 +25,8 @@ Rotate in the given direction (backward by default). | |||
|
|
|||
| ### `unit.rescue([direction])`: | |||
|
|
|||
| Rescue a captive from his chains (earning `[rescuingReward]` points) in the | |||
| given direction (forward by default). | |||
| Rescue a captive from his chains (earning points) in the given direction | |||
There was a problem hiding this comment.
I think that "earning a reward" is slightly better than "earning points".
|
|
||
| function rescue() { | ||
| return unit => ({ | ||
| action: true, | ||
| description: `Rescue a captive from his chains (earning ${rescuingReward} points) in the given direction (${defaultDirection} by default).`, | ||
| description: `Rescue a captive from his chains (earning points) in the given direction (${defaultDirection} by default).`, |
Allow the rescue ability to award the number of points assigned to the unit being rescued.
|
Gotcha, description changed from |
olistic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the rescue ability to award the number of points assigned to the unit being rescued.
Closes #64