-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRASH] FFmpeg 4.3 causes Olive to crash #1176
Comments
I'm experiencing crashes every time I try to place any video file on the timeline, could that be related? Build:
Backtrace:
ffprobe on the input video file:
|
I think you might be onto something! If you build FFmpeg from source and rebuild Olive and you'll be fine. |
@unfa Yep that's the one. Unfortunately the AppImage is on a rolling release of FFmpeg so we can't downgrade it. We're very much in the process of switching to a Docker based CI that will give us full control over the versions |
@unfa sorry I misread and thought you were building yourself. |
@itsmattkc should we go with 4.2.4 or rather 4.4.dev? Are there any benefits like performance or features in the latest nightlies? |
I'd lean towards stability and stick with 4.2 personally. I think there are performance improvements in 4.3+ (pretty sure that's what causes this crash), but I'd rather wait for them to become stable. |
Linux CI is merged, but the nightly page doesn't list them yet. @itsmattkc I guess you need to adjust the PHP script a little? |
Actually the uploads aren't coming through because Cloudflare limits upload size to 100MB on free accounts... I might need to find an alternative means of uploading. |
Linux builds are officially up. Anyone suffering from this issue on a user-compiled build should use these instead until FFmpeg is updated. |
Would tracking this issue be the best way to hear when FFmpeg 4.3.2 is released/works? |
Yeah I'll update here whenever FFmpeg's current version has implemented the fix. |
I can not export my project with current 0.2 (on windows) in ANY way (mp4, quicktime - h264/h265/prores). NONE of the offered formats work. Other well known formats like webm or mpeg2 are missing. It is very nice to have beta software and continuous releases, but please state in the download section, that exports are currently NOT working. Don't let people run into a dead end. |
There is a difference between unstable and not working. But not having ANY way (not even mpeg2) to export the result is just a downer. I get downvoted here. But I think the user reception and reputation of the project (see reddit) is very important as well. As long as exports are not working, I think the warning should include that explicitly and the link to the old version 0.1 should be offered more prominently. |
Once again, you're assuming we all know that export isn't working. I haven't run into any issues exporting so far. It isn't working for you on your setup, yes that's definitely a problem, but if we've never encountered the bug and no one's reported it before, how are we supposed to know about it? |
@zevero When wording your feedback please keep in mind that @itsmattkc and the other contributors to the project have volunteered their time and energy out of no obligation to you. Also, as the title "FFmpeg 4.3 causes Olive to crash" suggests, this issue is about crashes with Olive built with FFmpeg 4.3, not about exporting. |
Both 0.1 and 0.2 are technically alpha software - as the download page clearly states. Please take the term "alpha software" seriously. You cannot even take for granted that Olive starts (this is an actual issue for some users). Please report problems, one GitHub issue each. |
I actually haven't seen this crash in a while despite being on 4.3. We did change some of the frame storage code, so I think that might have worked around it. I think I'll mark this as no longer an issue, however I still recommend people avoid this version and use either 4.2 or the git master of FFmpeg. |
Commit Hash
Any
Platform
Any
Summary
If Olive is linked with FFmpeg 4.3.x, it crashes when trying to place a video into the timeline.
This bug is tracked on FFmpeg's tracker: https://trac.ffmpeg.org/ticket/8747
Workarounds
The text was updated successfully, but these errors were encountered: