Can now create a new jimp with the CSS hex color format #549
Conversation
src/index.js
Outdated
|
|
||
| if (typeof cssColor === 'number') return Number(cssColor); | ||
|
|
||
| const color = new tinyColor(cssColor); |
There was a problem hiding this comment.
I don't think the new is required here.
README.md
Outdated
| @@ -504,6 +504,12 @@ Jimp.rgbaToInt(r, g, b, a); // e.g. converts 255, 255, 255, 255 to 0xFFFFFFFF | |||
| Jimp.intToRGBA(hex); // e.g. converts 0xFFFFFFFF to {r: 255, g: 255, b: 255, a:255} | |||
| ``` | |||
|
|
|||
| You can convert a css hex color to its true rgba hexadecimal equivalent: | |||
There was a problem hiding this comment.
It seems like tinycolor2 can take more than just a hex value.
https://www.npmjs.com/package/tinycolor2
Can you update this to reflect that you can also pass in RGB, RGBA, HSL, HSLA, HSV, HSVA, and named values also?
test/events.test.js
Outdated
| done(); | ||
| }) | ||
| .on('error', done); | ||
| }); |
There was a problem hiding this comment.
And add a test or two for the above mentioned extra color formats
There was a problem hiding this comment.
Also can you switch these tests to async await?
it('initializes with a color', async () => {
const image = await Jimp.create(2, 2, 0xffffffff)
image.getPixelColor(1, 1).should.be.equal(0xffffffff);
});
|
Sure. Also I don't know why the pr diff is so much in jimp.d.ts I only added 5 lines. |
|
@CodySchrank the type file looks fine! it's done that on other PRs also, weird for sure. |
|
I'll let you deal with the docs because now there's a bunch of ways to add a color and I don't know how you want to show that in the readme. |
|
@CodySchrank thanks for your work! |
|
@hipstersmoothie Thanks for maintaining this I've been using it heavily. |
hipstersmoothie
added
the
enhancement
What's Changing and Why
Adds the popular css hex color format for creating a new jimp.
new Jimp(512, 512, '#D95353', (image) => {});What else might be affected
Added a conversion function from css hex color to hex
Also added tests for creating image with hex color and css color.