Has alpha #585
Merged
Has alpha #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
added
the
enhancement
hipstersmoothie
force-pushed
the
hasAlpha
branch
from
1d8b67b
to
4ebd8e2
Compare
edi9999
reviewed
Sep 1, 2018
packages/jimp/test/filetypes.test.js
Outdated
| @@ -135,3 +135,17 @@ describe('FileType', () => { | |||
| image.bitmap.data.should.be.deepEqual(expectedImg.bitmap.data); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('hasAlpah', () => { | |||
edi9999
reviewed
Sep 1, 2018
packages/core/src/index.js
Outdated
| const alpha = this.bitmap.data[idx + 3]; | ||
|
|
||
| if (alpha !== 0xff) { | ||
| hasAlpha = true; |
There was a problem hiding this comment.
I'm not sure how well v8 and others engines read the code ahead, but wouldn't it be faster to return early ?
There was a problem hiding this comment.
the for loops check for hasAlpha to be false so once if find an alpha channel both the loops break. I will go through every pixel if it doesn't find an alpha channel though.
edi9999
reviewed
Sep 1, 2018
README.md
Outdated
| @@ -11,6 +11,8 @@ An image processing library for Node written entirely in JavaScript, with zero n | |||
|
|
|||
| Installation: `npm install --save jimp` | |||
|
|
|||
| API documnetation can be found in the main [jimp package](./packages/jimp) | |||
|
@edi9999 comments addressed |
Closed
hipstersmoothie
force-pushed
the
hasAlpha
branch
from
6c22da2
to
c80b4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
determine if an image is using the alpha channel.
closes #271
What else might be affected
Tasks
jimp.d.ts