Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Core-JS as a dependency. #882

Merged
merged 3 commits into from
May 2, 2020
Merged

Conversation

EricRabil
Copy link
Contributor

@EricRabil EricRabil commented May 2, 2020

What's Changing and Why

I removed Core-JS as a dependency, per #769
It is not the responsibility of this library to polyfill the environment of a developer - it is the responsibility of the developer to polyfill their environment as they see fit.
The longest part of my install in projects that use jimp is getting spammed with 30 messages from core-js to either update or donate.

In the words of @laino,

This is not something you should do for the user of your library, ever.

It's my job to provide your lib an environment it can run in, it's not the job of an image library to go messing with it.

Let me worry about polyfilling stuff or not polyfilling stuff. Now I have to ship core-js just to get jimp working.

Maybe have a @jimp/polyfills repo if you want to provide auto-polyfilling.

What else might be affected

People working in environments where they don't explicitly depend on core-js will have to explicitly install core-js if they still need it.

Tasks

  • Add tests (n/a - this simply removes polyfilling, and all tests passed)
  • Update Documentation
  • Update jimp.d.ts (n/a - no types are affected by this)
  • Add SemVer Label
📦 Published PR as canary version: 0.10.5-canary.882.886.0

✨ Test out this PR locally via:

npm install @jimp/cli@0.10.5-canary.882.886.0
npm install @jimp/core@0.10.5-canary.882.886.0
npm install @jimp/custom@0.10.5-canary.882.886.0
npm install jimp@0.10.5-canary.882.886.0
npm install @jimp/plugin-blit@0.10.5-canary.882.886.0
npm install @jimp/plugin-blur@0.10.5-canary.882.886.0
npm install @jimp/plugin-circle@0.10.5-canary.882.886.0
npm install @jimp/plugin-color@0.10.5-canary.882.886.0
npm install @jimp/plugin-contain@0.10.5-canary.882.886.0
npm install @jimp/plugin-cover@0.10.5-canary.882.886.0
npm install @jimp/plugin-crop@0.10.5-canary.882.886.0
npm install @jimp/plugin-displace@0.10.5-canary.882.886.0
npm install @jimp/plugin-dither@0.10.5-canary.882.886.0
npm install @jimp/plugin-fisheye@0.10.5-canary.882.886.0
npm install @jimp/plugin-flip@0.10.5-canary.882.886.0
npm install @jimp/plugin-gaussian@0.10.5-canary.882.886.0
npm install @jimp/plugin-invert@0.10.5-canary.882.886.0
npm install @jimp/plugin-mask@0.10.5-canary.882.886.0
npm install @jimp/plugin-normalize@0.10.5-canary.882.886.0
npm install @jimp/plugin-print@0.10.5-canary.882.886.0
npm install @jimp/plugin-resize@0.10.5-canary.882.886.0
npm install @jimp/plugin-rotate@0.10.5-canary.882.886.0
npm install @jimp/plugin-scale@0.10.5-canary.882.886.0
npm install @jimp/plugin-shadow@0.10.5-canary.882.886.0
npm install @jimp/plugin-threshold@0.10.5-canary.882.886.0
npm install @jimp/plugins@0.10.5-canary.882.886.0
npm install @jimp/test-utils@0.10.5-canary.882.886.0
npm install @jimp/bmp@0.10.5-canary.882.886.0
npm install @jimp/gif@0.10.5-canary.882.886.0
npm install @jimp/jpeg@0.10.5-canary.882.886.0
npm install @jimp/png@0.10.5-canary.882.886.0
npm install @jimp/tiff@0.10.5-canary.882.886.0
npm install @jimp/types@0.10.5-canary.882.886.0
npm install @jimp/utils@0.10.5-canary.882.886.0
# or 
yarn add @jimp/cli@0.10.5-canary.882.886.0
yarn add @jimp/core@0.10.5-canary.882.886.0
yarn add @jimp/custom@0.10.5-canary.882.886.0
yarn add jimp@0.10.5-canary.882.886.0
yarn add @jimp/plugin-blit@0.10.5-canary.882.886.0
yarn add @jimp/plugin-blur@0.10.5-canary.882.886.0
yarn add @jimp/plugin-circle@0.10.5-canary.882.886.0
yarn add @jimp/plugin-color@0.10.5-canary.882.886.0
yarn add @jimp/plugin-contain@0.10.5-canary.882.886.0
yarn add @jimp/plugin-cover@0.10.5-canary.882.886.0
yarn add @jimp/plugin-crop@0.10.5-canary.882.886.0
yarn add @jimp/plugin-displace@0.10.5-canary.882.886.0
yarn add @jimp/plugin-dither@0.10.5-canary.882.886.0
yarn add @jimp/plugin-fisheye@0.10.5-canary.882.886.0
yarn add @jimp/plugin-flip@0.10.5-canary.882.886.0
yarn add @jimp/plugin-gaussian@0.10.5-canary.882.886.0
yarn add @jimp/plugin-invert@0.10.5-canary.882.886.0
yarn add @jimp/plugin-mask@0.10.5-canary.882.886.0
yarn add @jimp/plugin-normalize@0.10.5-canary.882.886.0
yarn add @jimp/plugin-print@0.10.5-canary.882.886.0
yarn add @jimp/plugin-resize@0.10.5-canary.882.886.0
yarn add @jimp/plugin-rotate@0.10.5-canary.882.886.0
yarn add @jimp/plugin-scale@0.10.5-canary.882.886.0
yarn add @jimp/plugin-shadow@0.10.5-canary.882.886.0
yarn add @jimp/plugin-threshold@0.10.5-canary.882.886.0
yarn add @jimp/plugins@0.10.5-canary.882.886.0
yarn add @jimp/test-utils@0.10.5-canary.882.886.0
yarn add @jimp/bmp@0.10.5-canary.882.886.0
yarn add @jimp/gif@0.10.5-canary.882.886.0
yarn add @jimp/jpeg@0.10.5-canary.882.886.0
yarn add @jimp/png@0.10.5-canary.882.886.0
yarn add @jimp/tiff@0.10.5-canary.882.886.0
yarn add @jimp/types@0.10.5-canary.882.886.0
yarn add @jimp/utils@0.10.5-canary.882.886.0

@EricRabil
Copy link
Contributor Author

EricRabil commented May 2, 2020

I had a change of heart after some self-reflection :) I apologize for my rant.

And I wholeheartedly agree, I'm sorry that I spoke the way that I did – per why I removed it – and again I sincerely apologize for the way I spoke in #769. It was unprofessional and disrespectful to the contributors of this project.

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label May 2, 2020
@hipstersmoothie hipstersmoothie merged commit 585c1ab into jimp-dev:master May 2, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.11.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants