Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect metrics for config options #13

Closed
oliver006 opened this issue Jul 18, 2016 · 10 comments
Closed

Collect metrics for config options #13

oliver006 opened this issue Jul 18, 2016 · 10 comments

Comments

@oliver006
Copy link
Owner

Collecting metrics for config options like max_memory could be useful and should be easy to implement by parsing the output of CONFIG GET *.

@jkemp101
Copy link

jkemp101 commented Nov 3, 2016

CONFIG isn't available in AWS ElasticCache Redis. A flag would useful to disable this check. Right now it errors and then doesn't do the check-keys because of the continue.

@oliver006
Copy link
Owner Author

Ah, interesting.
Let me fix that so it continues even if it can't get the CONFIG output.

@jkemp101
Copy link

jkemp101 commented Nov 8, 2016

Thanks for the fix, just deployed latest version and it works great. Passing 1025 queues on the command line for -check-keys is also surprisingly working.

@oliver006
Copy link
Owner Author

Wow, over 1k for check-keys is a lot, would regex or wildcard matching help in your case?

@jkemp101
Copy link

jkemp101 commented Nov 9, 2016

A wildcard would definitely be cleaner but the command line list is working for now. I don't expect the list to expand for now.

@oliver006
Copy link
Owner Author

👍

@mrwacky42
Copy link
Contributor

For the record, in AWS ElastiCache Redis, a maxmemory value is returned in the results of the INFO memory command. Perhaps it would be nice to add an option to look there instead?

@cbarratt
Copy link

^ The above would be great, I'm using Redis on Heroku and the CONFIG option is also disabled there! Retrieving the data from INFO would be a good option to have.

@oliver006
Copy link
Owner Author

@cbarratt - this should be fixed via #64 and released as https://github.com/oliver006/redis_exporter/releases/tag/v0.11

@plynte
Copy link

plynte commented Nov 1, 2017

maxmemory --> "redis_memory_max_bytes" after v0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants