Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching extra config metrics fails on cloud managed Redis instances #905

Closed
ccorbacho opened this issue May 17, 2024 · 1 comment · Fixed by #915
Closed

Fetching extra config metrics fails on cloud managed Redis instances #905

ccorbacho opened this issue May 17, 2024 · 1 comment · Fixed by #915

Comments

@ccorbacho
Copy link

Describe the problem
Attempts to fetch the extra config metrics for a Redis instance fail on cloud managed Redis instances - on at least AWS Elasticache and GCP Memorystore.

{"level":"debug","msg":"c.Do() - err: ERR unknown command 'CONFIG', with args beginning with: 'GET' '*' ","time":"2024-05-17T10:11:09Z"}
{"level":"debug","msg":"c.Do() - done","time":"2024-05-17T10:11:09Z"}
{"level":"debug","msg":"Redis CONFIG err: ERR unknown command 'CONFIG', with args beginning with: 'GET' '*' ","time":"2024-05-17T10:11:09Z"}

CONFIG is not an allowed command on most cloud managed Redis:

(This doesn't stop anything else, as the exporter continues onto the next ste of metrics).

What version of redis_exporter are you running?
1.59.0

Running the exporter
N/A (using the Docker image).

Expected behavior
Redis Exporter has a way to disable fetching the config metrics.

e.g. maybe a new environment variable to disable fetching these, so that we don't issue a command that will never succeed (and avoid these error messages when debug level logging is enabled).

Screenshots
N/A

Additional context
Add any other context about the problem here.

@oliver006
Copy link
Owner

I like the idea of adding a flag to skip calling the CONFIG command, I think that makes sense. Alas, I don't have the bandwidth right now to add the feature myself.
Feel free to open a PR, happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants