Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip CONFIG call #915

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Conversation

oliver006
Copy link
Owner

Fixes #905

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.52%. Comparing base (4b1e805) to head (6e280fa).

Files Patch % Lines
exporter/exporter.go 63.63% 3 Missing and 1 partial ⚠️
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   80.49%   80.52%   +0.02%     
==========================================
  Files          17       17              
  Lines        2338     2341       +3     
==========================================
+ Hits         1882     1885       +3     
  Misses        373      373              
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 363

Details

  • 7 of 12 (58.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.085%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
exporter/exporter.go 7 11 63.64%
Totals Coverage Status
Change from base Build 362: -0.02%
Covered Lines: 1976
Relevant Lines: 2350

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 364

Details

  • 7 of 12 (58.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.085%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
exporter/exporter.go 7 11 63.64%
Totals Coverage Status
Change from base Build 362: -0.02%
Covered Lines: 1976
Relevant Lines: 2350

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 366

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.128%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
exporter/exporter.go 8 11 72.73%
Totals Coverage Status
Change from base Build 362: 0.02%
Covered Lines: 1977
Relevant Lines: 2350

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 9, 2024

Pull Request Test Coverage Report for Build 365

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.128%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 1 0.0%
exporter/exporter.go 8 11 72.73%
Totals Coverage Status
Change from base Build 362: 0.02%
Covered Lines: 1977
Relevant Lines: 2350

💛 - Coveralls

@oliver006 oliver006 merged commit e9871c1 into master Jun 9, 2024
8 of 9 checks passed
@oliver006 oliver006 deleted the oh_add_flag_to_skip_CONFIG_call branch June 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching extra config metrics fails on cloud managed Redis instances
2 participants