Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to skip collecting latency histogram metric #913

Merged
merged 1 commit into from
May 31, 2024

Conversation

Nklya
Copy link
Contributor

@Nklya Nklya commented May 30, 2024

It fixes: #784 via 3rd option you mentioned here #784 (comment)

Accidentally closed previous PR #911 due to mess-up with force pushes.
Tested it locally, works as expected.
Can check adding tests later on weekend if needed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 357

Details

  • 3 of 80 (3.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 84.107%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 77 0.0%
Totals Coverage Status
Change from base Build 355: -0.07%
Covered Lines: 1974
Relevant Lines: 2347

💛 - Coveralls

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good. You can add the test in a follow-up PR if you like, not urgent. Let me merge this and release a new version

@oliver006 oliver006 merged commit de84178 into oliver006:master May 31, 2024
4 of 5 checks passed
@Nklya
Copy link
Contributor Author

Nklya commented May 31, 2024

Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Histogram Collection Creates Errors on Each Scrape With Older Redis Versions
3 participants