fix: fixed Stream.ReadSingle returning wrong type

ReadSingle previously returned a double, and this never failed unit tests since float -> double is a widening conversion, with values being comparable.
oliverbooth · Apr 1, 2023 · 677259b · 677259b
1 parent b2a27cd
commit 677259b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -144,6 +144,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - X10D: `T[].Clear` will now correctly clear the specified range of elements by
   using the [GetOffsetAndLength](https://learn.microsoft.com/en-us/dotnet/api/system.range.getoffsetandlength?view=net-7.0)
   method.
+- X10D: `Stream.ReadSingle(Endianness)` now returns a float instead of a double.
 
 ### Changed
 

diff --git a/X10D/src/IO/StreamExtensions.cs b/X10D/src/IO/StreamExtensions.cs
@@ -1,4 +1,4 @@
-using System.Buffers.Binary;
+using System.Buffers.Binary;
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Security.Cryptography;
@@ -345,7 +345,7 @@ public static double ReadSingle(this Stream stream)
     /// <param name="stream">The stream from which the value should be read.</param>
     /// <param name="endianness">The endian encoding to use.</param>
     /// <returns>A single-precision floating point value read from the stream.</returns>
-    public static double ReadSingle(this Stream stream, Endianness endianness)
+    public static float ReadSingle(this Stream stream, Endianness endianness)
     {
 #if NET6_0_OR_GREATER
         ArgumentNullException.ThrowIfNull(stream);