Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for methods introduced by #70 #73

Closed
Tracked by #68
oliverbooth opened this issue Mar 28, 2023 · 1 comment · Fixed by #68
Closed
Tracked by #68

Add unit tests for methods introduced by #70 #73

oliverbooth opened this issue Mar 28, 2023 · 1 comment · Fixed by #68
Assignees
@oliverbooth
Labels
enhancement New feature or request net6.0 Issue applies to .NET 6. net7.0 Issue applies to .NET 7. netstandard2.1 Issue applies to .NET Standard 2.1. triaged High-priority issue
Projects
X10D
Milestone
3.2.0

Comments

@oliverbooth
Copy link
Owner

Paging @RealityProgrammer, #70 introduced methods that have minimal coverage in unit tests.
Since I'm unfamiliar with some of the API, it would be appreciated if you could contribute in increasing coverage of these methods.
@oliverbooth oliverbooth added the enhancement New feature or request label Mar 28, 2023
@oliverbooth oliverbooth added this to the 3.2.0 milestone Mar 28, 2023
@oliverbooth oliverbooth added this to To do in X10D via automation Mar 28, 2023
@oliverbooth oliverbooth mentioned this issue Mar 28, 2023
Merged
16 tasks
@oliverbooth oliverbooth linked a pull request Mar 28, 2023 that will close this issue
3.2.0 update #68
Merged
16 tasks
@oliverbooth oliverbooth self-assigned this Apr 1, 2023
oliverbooth referenced this issue Apr 1, 2023
@oliverbooth
test: bring coverage to 100% for integer Unpack (#70)
87b6dbd
oliverbooth added a commit that referenced this issue Apr 1, 2023
@oliverbooth
test: add tests for CorrectBoolean (#73)
6f16c0d
oliverbooth added a commit that referenced this issue Apr 1, 2023
@oliverbooth
test: add tests for ReverseElements (#73)
586057b
oliverbooth added a commit that referenced this issue Apr 2, 2023
@oliverbooth
test: add unit tests for Span.Contains(Enum) (#73)
78cebbc
oliverbooth added a commit that referenced this issue Apr 2, 2023
@oliverbooth
test: add tests for ReadOnlySpan.Pack (#73)
22d5f07 
1 failing test: PackInt32Internal_Sse2_ShouldReturnCorrectInt32_GivenReadOnlySpan

This will fail the dotnet workflow.
oliverbooth added a commit that referenced this issue Apr 3, 2023
@oliverbooth
test: add tests for integer Pack (#73)
783c4b0
@oliverbooth oliverbooth added triaged High-priority issue netstandard2.1 Issue applies to .NET Standard 2.1. net6.0 Issue applies to .NET 6. net7.0 Issue applies to .NET 7. labels Apr 3, 2023
oliverbooth added a commit that referenced this issue Apr 3, 2023
@oliverbooth
test: 100% coverage on IntrinsicUtility (#73)
6ef48fc
@oliverbooth
Copy link
Owner Author

6ef48fc represented the last of coverage required. Resolved.

X10D automation moved this from To do to Done Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverbooth oliverbooth

Labels
enhancement New feature or request net6.0 Issue applies to .NET 6. net7.0 Issue applies to .NET 7. netstandard2.1 Issue applies to .NET Standard 2.1. triaged High-priority issue
Projects
X10D
Done
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

3.2.0 update oliverbooth/X10D
1 participant
@oliverbooth