Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove throw helpers (resolves #80) #81

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Remove throw helpers (resolves #80) #81

merged 2 commits into from
Apr 13, 2023

Conversation

oliverbooth
Copy link
Owner

This PR resolves #80 by removing all calls to ArgumentNullException.ThrowIfNull, replacing them with a null check and explicit throw statement

@oliverbooth oliverbooth added the enhancement New feature or request label Apr 13, 2023
@oliverbooth oliverbooth added this to the 4.0.0 milestone Apr 13, 2023
@oliverbooth oliverbooth added this to In progress in X10D via automation Apr 13, 2023
@oliverbooth oliverbooth self-assigned this Apr 13, 2023
@oliverbooth oliverbooth linked an issue Apr 13, 2023 that may be closed by this pull request
Remove calls to throw helpers for validating input #80
Closed
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@oliverbooth oliverbooth merged commit ccef1cd into release/4.0.0 Apr 13, 2023
X10D automation moved this from In progress to Done Apr 13, 2023
@oliverbooth oliverbooth deleted the dev/remove_throwhelpers branch April 13, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverbooth oliverbooth

Labels
enhancement New feature or request
Projects
X10D
Done
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Remove calls to throw helpers for validating input
1 participant
@oliverbooth