Add support for generic math #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces an experiment, to add support for generic math in X10D. So far, build and tests remain passing - this is a good sign. There is potential here. This API is subject to change and may be removed without warning.
I'm an idiot.
oliverbooth
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/4.0.0 #84 +/- ##
=================================================
+ Coverage 97.71% 97.96% +0.25%
=================================================
Files 141 144 +3
Lines 3548 3595 +47
Branches 865 874 +9
=================================================
+ Hits 3467 3522 +55
Misses 20 20
+ Partials 61 53 -8 ☔ View full report in Codecov by Sentry. |
can't have coverage on SSE3/AVX2 instructions if CPU doesn't support it.
remove partial coverage by checking for 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @RealityProgrammer
This change introduces extension methods for the generic math interfaces introduced in .NET 7. Most of the extension methods which were duplicated for all built in numeric types have been changed to accept
INumber,IBinaryInteger, or a similar interface, in their stead.This also means that any additional types I've missed are covered, and also covers any future numeric types .NET may plan to add as well as any custom defined types.