Support reindex as asynchronous task #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
WaitForCompletion
parameter is set totrue
, the response from ElasticSearch is in a different format, as it just contains a task id. This PR provides aStart
method on the ReindexService that will return the task id instead of theBulkIndexByScrollResponse
, which is not appropriate for asynchronous requests. (I believe this could also be appropriate for the other Elastic APIs that have aWaitForCompletion
parameter, although my present use case does not extend to them).Secondly, the
TasksListService
does not work as expected with singletaskId
andnodeId
values, so, for the simple case of monitoring a single task, I have added aTasksGetTaskService
.