Support reindex as asynchronous task #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to Elastic. The PR is looking good. Give me some time to make a few more tests. But I hope it'll make it into the next release. |
olivere
added a commit
that referenced
this pull request
Jul 18, 2017
This commit adds to PR #550 and changes a few things. First, the Reindex.Start method is renamed to DoAsync to reflect that Do starts the request. Reindex.DoAsync starts reindexing in the background and returns a task id, which can be watched via the Task Get API, which was also added in #550. Furthermore, it adds some tests and missing fields in the response types, and fixes a typo or two in the JSON structs. See #550
|
I changed a few things in your original PR. See 3116eca for a summary. Most noticeable is that I renamed |
|
Forgot: This will make it into 5.0.42, which I'll release once CI is green. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
WaitForCompletionparameter is set totrue, the response from ElasticSearch is in a different format, as it just contains a task id. This PR provides aStartmethod on the ReindexService that will return the task id instead of theBulkIndexByScrollResponse, which is not appropriate for asynchronous requests. (I believe this could also be appropriate for the other Elastic APIs that have aWaitForCompletionparameter, although my present use case does not extend to them).Secondly, the
TasksListServicedoes not work as expected with singletaskIdandnodeIdvalues, so, for the simple case of monitoring a single task, I have added aTasksGetTaskService.