Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): add IsConflict checker #562

Merged
merged 1 commit into from Jul 18, 2017

Conversation

connor4312
Copy link
Contributor

Self-explanatory!

@olivere
Copy link
Owner

olivere commented Jul 18, 2017

Thanks for contributing to Elastic. This seems like a good choice, knowing that it's a typical ES response code. However, I think I'll refactor it a bit and extract a IsStatusCode(code int), then use that for both IsConflict and IsNotFound.

@olivere olivere merged commit 5b4cd4e into olivere:release-branch.v5 Jul 18, 2017
@connor4312 connor4312 deleted the conflict-err-checker branch July 18, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants