Generic handler #71
Merged
Generic handler #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Fields method to ScanService that allows the caller to speficy the fields to load. The Reindexer now requests the _parent and _router fields (on top of the default _source field). When the reindexer finds those fields in the hit, it sets them on the IndexRequest. In index_test: Added a new 'comment' type that is a child of 'tweet' together with its mapping. Added a comment instance to the test dataset.
|
👍 Much better than before. Flexible and simpler design. Is |
|
If we're going to stay with |
|
Okay, I see that you've renamed the callback. I think it's better now. Are you still working on some details? Otherwise I'll merge it. |
|
I think it's good like this. Thank you for pushing the enveloppe |
olivere
added a commit
that referenced
this pull request
Apr 28, 2015
Added a Fields method to ScanService that allows the caller to speficy the fields to load. Redesigned the Reindexer and make it more generic. It now takes a ReindexerFunc that is responsible for consuming a SearchHit and handling the bulk operation (e.g. indexing, updating, deleting, or skipping the document). The default operation is CopyToTargetIndex which copies the SearchHit into the target index. CopyToTargetIndex also gracefully handles the _parent and _routing fields (on top of the default _source field). When CopyToTargetIndex finds those fields in the hit, it sets them in the IndexRequest. Tests: Added a new 'comment' type that is a child of 'tweet' together with its mapping. Added a comment instance to the test dataset. Also added some more Reindexer tests. Thanks to @nwolff for this PR. Closes #68 and #71.
|
It was a pleasure working with you. Thank you. |
|
Same here, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reindexer now takes a HitHandler than can emit any kind of BulkRequest
We provide a CopyToTargetIndex function to handle the common case of straighforward copying from one index to another.