Fix form handling in IE 10. #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IE10, it seems that normal links are routed fine, but forms are not. Minimal example: http://jsfiddle.net/xg4Hr/2/ - In Firefox and Chrome, clicking the GET and POST buttons display "GET" and "POST" as you'd expect. In IE10, the Davis.js routing is ignored and you get a 404 error. I narrowed the problem down to the `originChecks` function in davis.listener.js, on this line: a.href = elem.action In Firefox and Chrome, this will make `a.host` equal to the domain name. In IE10, the port number gets stuck on the end of `a.host`, for some reason. This makes `this.A(a)` on the next line return false since Davis.js thinks it is an external link. I worked around this by creating `a2` to compare with `a`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IE10, it seems that normal links are routed fine, but forms are not.
Minimal example: http://jsfiddle.net/xg4Hr/2/ - In Firefox and Chrome,
clicking the GET and POST buttons display "GET" and "POST" as you'd
expect. In IE10, the Davis.js routing is ignored and you get a 404
error. I narrowed the problem down to the
originChecksfunction indavis.listener.js, on this line:
In Firefox and Chrome, this will make
a.hostequal to the domainname. In IE10, the port number gets stuck on the end of
a.host, forsome reason. This makes
this.A(a)on the next line return false sinceDavis.js thinks it is an external link. I worked around this by creating
a2to compare witha.