Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Commit

Permalink
refactor: Remove redundant classes argument
Browse files Browse the repository at this point in the history
  • Loading branch information
oliversalzburg committed Oct 16, 2022
1 parent e0f90c7 commit 90b241f
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 20 deletions.
3 changes: 1 addition & 2 deletions packages/userscript/source/ui/FilterSettingsUi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ export class FiltersSettingsUi extends SettingsSectionUi<FilterSettings> {
onUnCheck: () => this._host.engine.imessage("filter.disable", [label]),
},
false,
false,
[]
false
);

this._filters = buttonTemplates
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export class SettingLimitedListItem extends SettingListItem {
* @param delimiter Should a delimiter be rendered after this element?
* @param upgradeIndicator Should an indicator be rendered in front of the elemnt,
* to indicate that this is an upgrade of a prior setting?
* @param additionalClasses A list of CSS classes to attach to the element.
*/
constructor(
host: UserScript,
Expand All @@ -34,10 +33,9 @@ export class SettingLimitedListItem extends SettingListItem {
onLimitedUnCheck: () => void;
},
delimiter = false,
upgradeIndicator = false,
additionalClasses = []
upgradeIndicator = false
) {
super(host, label, setting, handler, delimiter, upgradeIndicator, additionalClasses);
super(host, label, setting, handler, delimiter, upgradeIndicator);

this.limitedButton = new LimitedButton(host, setting, handler);
this.element.append(this.limitedButton.element);
Expand Down
6 changes: 2 additions & 4 deletions packages/userscript/source/ui/components/SettingListItem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export class SettingListItem extends UiComponent {
* @param delimiter Should there be additional padding below this element?
* @param upgradeIndicator Should an indicator be rendered in front of the elemnt,
* to indicate that this is an upgrade of a prior setting?
* @param additionalClasses A list of CSS classes to attach to the element.
*/
constructor(
host: UserScript,
Expand All @@ -31,13 +30,12 @@ export class SettingListItem extends UiComponent {
onUnCheck: () => void;
},
delimiter = false,
upgradeIndicator = false,
additionalClasses = []
upgradeIndicator = false
) {
super(host);

const element = $(`<li/>`);
for (const cssClass of ["ks-setting", delimiter ? "ks-delimiter" : "", ...additionalClasses]) {
for (const cssClass of ["ks-setting", delimiter ? "ks-delimiter" : ""]) {
element.addClass(cssClass);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export class SettingMaxListItem extends SettingListItem {
* @param delimiter Should a delimiter be rendered after this element?
* @param upgradeIndicator Should an indicator be rendered in front of the elemnt,
* to indicate that this is an upgrade of a prior setting?
* @param additionalClasses A list of CSS classes to attach to the element.
*/
constructor(
host: UserScript,
Expand All @@ -31,10 +30,9 @@ export class SettingMaxListItem extends SettingListItem {
onUnCheck: () => void;
},
delimiter = false,
upgradeIndicator = false,
additionalClasses = []
upgradeIndicator = false
) {
super(host, label, setting, handler, delimiter, upgradeIndicator, additionalClasses);
super(host, label, setting, handler, delimiter, upgradeIndicator);

this.maxButton = new MaxButton(host, label, setting);
this.element.append(this.maxButton.element);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ export class SettingTriggerLimitListItem extends SettingListItem {
onUnCheck: () => void;
},
delimiter = false,
upgradeIndicator = false,
additionalClasses = []
upgradeIndicator = false
) {
super(host, label, setting, handler, delimiter, upgradeIndicator, additionalClasses);
super(host, label, setting, handler, delimiter, upgradeIndicator);

this.triggerButton = new TriggerLimitButton(host, label, setting);
this.element.append(this.triggerButton.element);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ export class SettingTriggerListItem extends SettingListItem {
onUnCheck: () => void;
},
delimiter = false,
upgradeIndicator = false,
additionalClasses = []
upgradeIndicator = false
) {
super(host, label, setting, handler, delimiter, upgradeIndicator, additionalClasses);
super(host, label, setting, handler, delimiter, upgradeIndicator);

this.triggerButton = new TriggerButton(host, label, setting);
this.element.append(this.triggerButton.element);
Expand Down

0 comments on commit 90b241f

Please sign in to comment.