fix(trade): Embassy build limit behaves wrong

oliversalzburg · Oct 9, 2022 · d8092a6 · d8092a6
1 parent 2d6e454
commit d8092a6
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/userscript/source/TradeManager.ts b/packages/userscript/source/TradeManager.ts
@@ -300,7 +300,10 @@ export class TradeManager implements Automation {
 
       const name = racePanels[panelIndex].race.name;
       const race = this._host.gamePage.diplomacy.get(name);
-      const max = this.settings.buildEmbassies.items[name].max;
+      const max =
+        this.settings.buildEmbassies.items[name].max === -1
+          ? Number.POSITIVE_INFINITY
+          : this.settings.buildEmbassies.items[name].max;
 
       if (!this.settings.buildEmbassies.items[name].enabled || max <= race.embassyLevel) {
         continue;
@@ -333,6 +336,10 @@ export class TradeManager implements Automation {
           emBulk.priceSum += nextPrice;
           emBulk.val += 1;
           refreshRequired = true;
+
+          if (emBulk.max <= emBulk.val) {
+            continue;
+          }
         } else {
           bulkTracker.splice(raceIndex, 1);
           --raceIndex;