This repository has been archived by the owner on Oct 25, 2022. It is now read-only.
Settings overhaul #123
Merged
Settings overhaul #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1 of a series of refactorings to create a more useful, decoupled settings landscape. We no longer want to rely on object hashes and a global settings object.
Step 2 moves most accesses to settings into the managers. The global options object has been removed.
Step 3 moves all settings from `addition` blocks into their parrent settings container. This will make the next steps a lot less painful.
Step 4 provides `load()` interfaces on the manager to load new values into their settings.
Remove remaining reliance on `Options` when not interacting with the the (currently only existing) legacy settings storage.
This is still not surfaced in the UI, but the feature was always partially implemented and will be fully restored.
"Managers" should clearly relate to specific tabs in the game. Classes which serve other use cases should be in their own space.
Make all managers reference each other and use the single true settings object for each manager.
This enables setting the cap for resources to craft.
Ultimately, we want to have no more `css : ...` arguments for jQuery and control all styling through a common set of rules.
While the two UIs share similar functionality, it has been in distinct methods all along. It should be refactored into common parts later.
Stock indicators have already been added in a more visible way. If stock indicators should be extended or improved, it should happen on the established code path.
|
At this point, it's likely stable enough that further work can happen on the main branch. The changes are too extensive to integrate fixes we need right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes the layout of the settings data