Added more unit tests for search engine

oliverschwendener · May 16, 2018 · a19f98c · a19f98c
1 parent dc6e584
commit a19f98c
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/src/tests/unit/search-engine.test.ts b/src/tests/unit/search-engine.test.ts
@@ -1,5 +1,8 @@
 import { SearchResultItem } from "../../ts/search-result-item";
 import { SearchEngine } from "./../../ts/search-engine";
+import { CountManager } from "../../ts/count-manager";
+import {FakeCountRepository} from "./fake-count-repository";
+import { Count } from "../../ts/count";
 
 function getFakeItems(items: string[]): SearchResultItem[] {
     return items.map((i): SearchResultItem => {
@@ -43,5 +46,45 @@ describe("SearchEngine", (): void => {
             expect(actual.length).toBeGreaterThan(0);
             expect(actual[0].name).toBe("hans");
         });
+
+        it("should list frequently used items higher", (): void => {
+            const fakeCount: Count = {
+                abc: 5,
+                abcd: 6,
+                abcde: 7,
+            };
+            const fakeCountRepo = new FakeCountRepository(fakeCount);
+            const countManager = new CountManager(fakeCountRepo);
+            const fakeItems = getFakeItems(["abc", "abcd", "abcde"]);
+            const searchEngine = new SearchEngine(fakeItems);
+            const userInput = "ab";
+
+            const result = searchEngine.search(userInput, countManager);
+
+            expect(result.length).toBe(3);
+            expect(result[0].name).toBe("abcde");
+            expect(result[1].name).toBe("abcd");
+            expect(result[2].name).toBe("abc");
+        });
+
+        it("should not list frequently used items higher if their count is 4 or lower", (): void => {
+            const fakeCount: Count = {
+                abc: 1,
+                abcd: 2,
+                abcde: 3,
+            };
+            const fakeCountRepo = new FakeCountRepository(fakeCount);
+            const countManager = new CountManager(fakeCountRepo);
+            const fakeItems = getFakeItems(["abc", "abcd", "abcde"]);
+            const searchEngine = new SearchEngine(fakeItems);
+            const userInput = "ab";
+
+            const result = searchEngine.search(userInput, countManager);
+
+            expect(result.length).toBe(3);
+            expect(result[0].name).toBe("abc");
+            expect(result[1].name).toBe("abcd");
+            expect(result[2].name).toBe("abcde");
+        });
     });
 });
diff --git a/src/ts/search-engine.ts b/src/ts/search-engine.ts
@@ -47,7 +47,7 @@ export class SearchEngine {
         for (let i = 0; i < searchResults.length; i++) {
             const score = count[searchResults[i].item.executionArgument];
 
-            if (score !== undefined) {
+            if (score !== undefined && score > 4) {
                 searchResults[i].score /= (score * 0.25);
             }
         }