Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better icon for Windows Taskbar #67

Closed
wants to merge 1 commit into from
Closed

Better icon for Windows Taskbar #67

wants to merge 1 commit into from

Conversation

mkkeck
Copy link

@mkkeck mkkeck commented Nov 22, 2018

See this:
windows-icon

If taskbar in Windows not in light color, it's difficult to see the
icon.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 463

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 460: 0.0%
Covered Lines: 690
Relevant Lines: 690

💛 - Coveralls

@oliverschwendener
Copy link
Owner

oliverschwendener commented Dec 3, 2018

I see your point, the current icon can't be seen on white background. But maybe we should just use a black variant of the current icon instead of adding an outline. And only for Windows 7.

@oliverschwendener
Copy link
Owner

Or maybe use an icon with a solid black background

@mkkeck
Copy link
Author

mkkeck commented Dec 7, 2018

I think the outlined icon is much more flexible and looks better than one with solid background.
And why only for Windows 7?

@mkkeck
Copy link
Author

mkkeck commented Dec 7, 2018

I think, it does not make sense to post pull request here, if no one of this project want my work (perhaps it's not good enough or to many changes at once)
So I close this.

@mkkeck mkkeck closed this Dec 7, 2018
@oliverschwendener
Copy link
Owner

I really appreciate your effort and your interest in contributing to this project. But in my opinion the icon with the black outline just doesn't look good.

@olivereisenhut
Copy link

Hey @mkkeck. It is very hard for the maintainers of a project to process a big PR. There are a lot of changes without any context why something has changed an so on. I would suggest to create issues before creating any bigger PR. In those issues you can document the whats and whys. This helps to give context to changes and maybe it comes out that some changes are not even needed.

Just some thoughts from my site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants