Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor - open in new tab function seems to have stopped working #299

Open
anicede opened this issue Jan 12, 2018 · 5 comments
Open

Editor - open in new tab function seems to have stopped working #299

anicede opened this issue Jan 12, 2018 · 5 comments

Comments

@anicede
Copy link

anicede commented Jan 12, 2018

I used to be able to right click an item in the tree view within the editor and open it in a new tab. Now right clicking immediately replaces what was already in the editor with the right-clicked item, and nothing happens when selecting 'open in new tab'.

I'm using the develop branch, on Linux (Peppermint OS).

@gedakc
Copy link
Collaborator

gedakc commented Jan 12, 2018

Thank you @anicede for reporting an issue with the open text in a new tab right-click menu.

The way the right-click menu works was altered when we added a document menu -- see bottom section of comment and the follow up comments.

Due to the design choice we made to immediately select the text in the Project tree pane, the unfortunate side effect is that open text in a new tab is no longer functional. In fact because both open text and open text in a new tab currently work exactly the same, we should probably remove these two right-click menu options.

@olivierkes what are your thoughts on removing both open text and open text in a new tab right-click menus?

@anicede
Copy link
Author

anicede commented Jan 12, 2018

Is there another way of opening a new tab, so I can still have tabs? That was my first attempt at a fix, but I couldn't for the life of me figure it out. I'm aware that I can split the editor window, but that's not the function I'm after. (prior to Manuskript, I was using Geany for my writing projects, and my editing workflow has me opening all scenes in a chapter in tabs, so I can quickly flick between them - hopefully that gives an idea of how I'd like it to work)

@olivierkes
Copy link
Owner

olivierkes commented Jan 12, 2018

Thanks @anicede for raising that issue. For now, you can simply hold CTRL while clicking on an item, and it will load in a new tab.

what are your thoughts on removing both open text and open text in a new tab right-click menus?

@gedakc Yes it really makes no sense to keep them now... If we're sure that's the behavior we want :)
And then, @anicede makes sense: how can we inform users that they can use tab with CTRL-holding?

@anicede
Copy link
Author

anicede commented Jan 12, 2018

Cool, that'll work for me, thanks!

@gedakc
Copy link
Collaborator

gedakc commented Jan 13, 2018

Thanks @olivierkes for the tip on holding down Ctrl. This also works for opening multiple tabs by holding down Shift and then selecting Open # items in new tabs.

One way we might inform users to hold down Ctrl when opening in a new tab is to add a hover-over tip to that specific right-click menu entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants