Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python syntax warning upon installation #792

Closed
sm8ps opened this issue Aug 8, 2020 · 1 comment · Fixed by #762
Closed

Python syntax warning upon installation #792

sm8ps opened this issue Aug 8, 2020 · 1 comment · Fixed by #762
Labels
Milestone

Comments

@sm8ps
Copy link

sm8ps commented Aug 8, 2020

After issuing sudo apt install manuskript on Ubuntu 20.04, I see the following warning

manuskript (0.10.0-1) wird eingerichtet ...
/usr/share/manuskript/manuskript/exporter/pandoc/abstractPlainText.py:78: SyntaxWarning: "is" with a liter
al. Did you mean "=="?
  if self.formats is "":
/usr/share/manuskript/manuskript/importer/opmlImporter.py:124: SyntaxWarning: "is" with a literal. Did you
 mean "=="?
  return len(s) is 0
/usr/share/manuskript/manuskript/main.py:104: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if platform.system() is not 'Windows':

This looks like a typo to me as it is not valid Python syntax. At least the first one still is present in the current code (version 0.11) on Github.

@gedakc gedakc added the bug label Aug 10, 2020
@gedakc
Copy link
Collaborator

gedakc commented Aug 10, 2020

See PR #762 for a fix for this problem.

@gedakc gedakc added this to the 0.12.0 milestone Aug 10, 2020
@TheJackiMonster TheJackiMonster linked a pull request Feb 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants