Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes all properties which are prefixed by data-test #62

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

divmgl
Copy link
Contributor

@divmgl divmgl commented Feb 6, 2019

Closes #61

@divmgl
Copy link
Contributor Author

divmgl commented Feb 6, 2019

cc @oliviertassinari

@zslabs zslabs mentioned this pull request Feb 6, 2019
@divmgl
Copy link
Contributor Author

divmgl commented Feb 6, 2019

We may want to increase the version of this package and eventually update the README.md to say that users can now use the Node API to provide regular expressions to match on.

require('babel-core').transform('code', {
  plugins: [
    ['react-remove-properties', {properties: ['data-test', 'data-foo', /my-suffix-expression$/]}],
  ],
});

@oliviertassinari
Copy link
Owner

Yes, could you add a documentation note about it?

zslabs added a commit to zslabs/babel-plugin-react-remove-properties that referenced this pull request Feb 7, 2019
@zslabs
Copy link
Contributor

zslabs commented Feb 7, 2019

@oliviertassinari Created #63 if we're able to get both in at the same time and release a new version. Thanks!

oliviertassinari pushed a commit that referenced this pull request Feb 7, 2019
@oliviertassinari oliviertassinari merged commit 90462fb into oliviertassinari:master Feb 7, 2019
@oliviertassinari
Copy link
Owner

Well done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants