Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new prop-types package #87

Closed
kentcdodds opened this issue Apr 7, 2017 · 4 comments
Closed

support new prop-types package #87

kentcdodds opened this issue Apr 7, 2017 · 4 comments
Labels

Comments

@kentcdodds
Copy link

Today's announcement includes a deprecation of React.PropTypes and an introduction of a new package prop-types. I expect not a whole lot of code will need to be added to support this. I'm happy to do it with a little direction.

@kentcdodds
Copy link
Author

After thinking about it... I think that all we'd need to do is remove any import/require statements for prop-types and the normal plugin will handle the rest. Is this correct?

@oliviertassinari
Copy link
Owner

@kentcdodds Hey thanks, I was about to open an issue on that regard. I ended up with developit/proptypes#10. I'm expecting this plugin to be resilient to that API update. I still have to try it out.

@oliviertassinari
Copy link
Owner

oliviertassinari commented Apr 7, 2017

Oops, targeting the wrong repo import PropTypes from 'prop-types';.

@oliviertassinari
Copy link
Owner

I think that all we'd need to do is remove any import/require statements for prop-types

We have never supported that feature. I'm wondering if dead code eliminator like uglifyJS2 are able to handle it. I'm gonna open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants