safer type checking #179
Merged
safer type checking #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the existence of `node.property` before comparing `node.property.name`
|
Thanks for the fix! Can you please add a test that would have caught this? |
|
Yes, can we add a test so we don't break it again in the future? |
|
Alright I'll try to recreate ... this was caught by our crazy build system with a lot of nested stuff. Give me a few. |
In the scenario where you are importing from another file that has a `createClass` method with no name associated (such as a React abstraction), this can blow up if you have a custom `createReactClassName`.
oliviertassinari
approved these changes
Jan 15, 2019
|
Sorry to be pestilent, but now that the fix has tests and is approved and all that jazz ... is there anything blocking its release? We'd like to incorporate this into our build because it will have immediate tangible gains. 😺 |
|
@tquetano-netflix Well done! I'm releasing a patch :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the existence of
node.propertybefore comparingnode.property.nameFixes #178