Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Navigation? #106

Closed
oyeanuj opened this issue Jun 2, 2016 · 1 comment
Closed

Keyboard Navigation? #106

oyeanuj opened this issue Jun 2, 2016 · 1 comment
Labels
Browser enhancement

Comments

@oyeanuj
Copy link

oyeanuj commented Jun 2, 2016

Hi @oliviertassinari! While I know that this is intended mostly towards mobile use-cases, I was wondering if you plan to support keyboard navigation and ARIA attributes given that it works for browsers?

Thanks!
@oliviertassinari
Copy link
Owner

oliviertassinari commented Jun 2, 2016 •
edited

Hi,

  • I don't think that we should build the keyboard navigation in the core of the lib.
    But we could do something like the autoPlay HOC using react-event-listener 👍 .
  • Regarding the ARIA, I don't have any expertise on this field. What do you have in mind?

oliviertassinari added a commit that referenced this issue Sep 2, 2016
@oliviertassinari
[keyboard] Add a bind keyboard HOC
5a1b53b 
Closes #106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @oyeanuj