Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust react version in peerDependencies #640

Merged
merged 2 commits into from Apr 14, 2021
Merged

Adjust react version in peerDependencies #640

merged 2 commits into from Apr 14, 2021

Conversation

pgrodrigues
Copy link
Contributor

This PR addresses the version issue when using react-swipeable-views in a project with "react": "^17.0.1" as dependency and running npm install:

npm ERR! Found: react@17.0.1
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0" from react-swipeable-views@0.14.0-alpha.0
npm ERR! node_modules/react-swipeable-views
npm ERR!   react-swipeable-views@"^0.14.0-alpha.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Reproducible with Node.js v14.16.0 and npm v7.6.1.

Copy link

@douglaszaltron douglaszaltron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@seanflahertyT4
Copy link

if this is the only change, mind cutting a quick release?

@noamcohen97

This comment was marked as off-topic.

TheAnkurPanchani pushed a commit to TheAnkurPanchani/react-swipeable-views that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants