This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
Add absolute path support #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutervanvliet
suggested changes
Mar 13, 2018
| @@ -78,7 +78,7 @@ folder if you need a full working example. | |||
| - `entry`, **required**, *string*: | |||
| Path to the actual service worker implementation. | |||
| - `filename`, *string*, default `'sw.js'`: | |||
| Relative (from the webpack's config `output.path`) output path for emitted script. | |||
| Absolute or relative (from the webpack's config `output.path`) output path for emitted script. | |||
There was a problem hiding this comment.
Would you be able to add a testcase for this?
|
These changes, including the testcase, are currently included on the next branch. |
|
I had forgotten about this! Thank you and my apologies for abandoning the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the use of absolute paths for 'filename', in the case that the worker needs to be build to a separate location (Increased clarity vs using
../../).Credit goes entirely to @yyx990803 for writing this originally for html-webpack-plugin.
This also solves #20