Add output parser for dssim algo. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliyh
reviewed
Nov 13, 2020
src/clj/kamera/core.clj
Outdated
| @@ -147,7 +151,7 @@ | |||
| (.getAbsolutePath actual) | |||
| (.getAbsolutePath difference)] | |||
| opts) | |||
| mean-absolute-error (when-let [e (last (re-find #"all: .* \((.*)\)" stderr))] | |||
| mean-absolute-error (when-let [e ((compare-parsers metric) stderr)] | |||
There was a problem hiding this comment.
Might be a good idea to have a default too, so that we're not limiting the user to just the enumerated algos. Not sure which one would be better though, I guess the mae one would be best because people may already be using that one now with other algos.
There was a problem hiding this comment.
Also this was my oversight, but could we also rename the mean-average-error to be metric?
|
Fixes #32 (as combination of dssim and no :crop will address that in config options). |
|
Looks great @jleonard-r7 thanks, are you happy with how it works? I'll merge if so. |
|
Yep, it’s ready to merge. |
jleonard-r7
added a commit
to jleonard-r7/kamera
that referenced
this pull request
Nov 21, 2020
Co-authored-by: Jonathan Leonard <johanatan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32