Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi->handlers functionality #90

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Add openapi->handlers functionality #90

merged 1 commit into from
Aug 10, 2020

Conversation

czan
Copy link
Contributor

@czan czan commented Aug 9, 2020

I'm keen to use Martian for a project at work, but the specs that I have to interact with are OpenAPI3 rather than Swagger2. I tried using a converted from OpenAPI to Swagger, but they ended up yielding sub-par schemas (lots of optional keys and maybes that didn't match required fields in the spec).

In order to make Martian fit our project better, I've put together this martian.openapi namespace. I'm not claiming that it's a full implementation of the spec, and in particular the "content types" thing was a bit hastily thrown together, but this seems to be sufficient for what I need, and I figured it might be helpful for someone else, too.

I took inspiration from the martian.swagger namespace, but no code is shared with it.

@czan
Copy link
Contributor Author

czan commented Aug 9, 2020

Presumably if this ends up merged it would resolve #51.

@oliyh
Copy link
Owner

oliyh commented Aug 10, 2020

Hi,

Thank you! This looks great, #51 has been outstanding for ages. I will take a close look in a bit.

Cheers

@oliyh oliyh merged commit 61ee674 into oliyh:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants