Override superfetcher to allow misordered and missing results #28
Conversation
- Adds a second arity to the `def-superfetcher` macro to take two functions: one to define how to match input ids with response objects, and one to define what to do if there is a missing response object
|
Hi, Thanks for this contribution. I was wondering why you wouldn't just have this code in your fetching function, but then I guess the whole point of this macro is for convenience above all else. I was wondering if some better documentation would have saved you some time tracking down the cause of your recent issue that we spoke about on Slack, particularly now that there is this extra choice of how you can meet the contract? If you agree it would be useful to see that in the readme. Also would you be able to provide a test to exercise this code and serve as an example? Many thanks, let me know if I can help in any way. |
I'd be happy to add a test and document. I probably won't get to it until early next week, but that shouldn't be a problem. |
- Adds a second arity to the `def-superfetcher` macro to take two functions: one to define how to match input ids with response objects, and one to define what to do if there is a missing response object - Adds unit tests - Updates README
| @@ -170,6 +170,12 @@ We can rewrite this using superlifter (see the [example code](https://github.com | |||
| (with-superlifter context | |||
| (s/enqueue! :pet-details (->FetchPet id)))) | |||
| ``` | |||
| Note that when defining a Superfetcher as above, the number of outputs is | |||
There was a problem hiding this comment.
@oliyh Added this note to the README, but did not update the example. I started down that road, but it was starting to get ugly, as I started adding a whole parallel set of functions to support both superfetcher styles side-by-side with different queries.
If you'd like me to make that change - or have a different suggestion for the example project - let me know.
|
Hello, this looks good to me, thank you for your contribution |
|
Available now in |
Adds a second arity to the
def-superfetchermacro to take two functions: one to define how to match input ids with response objects, and one to define what to do if there is a missing response object