Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent return types for start() and conversion24bit() #48

Closed
Srijal97 opened this issue Oct 11, 2020 · 1 comment
Closed

Inconsistent return types for start() and conversion24bit() #48

Srijal97 opened this issue Oct 11, 2020 · 1 comment

Comments

@Srijal97
Copy link

The return type for HX711_ADC::start() is int, though it does not return anything.
The return type for HX711_ADC::conversion24bit() is uint8_t, though it also returns nothing.

It does compile fins with these errors in Arduino IDE, but I am getting errors in Sloeber. I have fixed them by modifying the source code, I suggest this is done here as well.

@olkal
Copy link
Owner

olkal commented Oct 19, 2020

Thanks, corrected in 1.2.4

@olkal olkal closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants