Some warnings from the compiler

[wollewald]

Hello @olkal,

first of all: great library!

When compiling your example sketches I get several warnings. You can easily improve the code:

• all variables which are related with millis(), e.g. t, startMultipleTimeStamp, startMultipleWaitTime should be defined as unsigned long
• variable t should be initialized with a value, e.g. t =0;
• there are few unused variables in your code

See all warnings below.

Best wishes, Wolfgang

C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\examples\Read_1x_load_cell\Read_1x_load_cell.ino: In function 'void loop()':
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\examples\Read_1x_load_cell\Read_1x_load_cell.ino:69:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (millis() > t + serialPrintInterval) {
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\examples\Read_1x_load_cell\Read_1x_load_cell.ino:80:11: warning: unused variable 'i' [-Wunused-variable]
float i;
^
In file included from C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\examples\Read_1x_load_cell\Read_1x_load_cell.ino:22:0:
C:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\libraries\EEPROM\src/EEPROM.h: At global scope:
C:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\libraries\EEPROM\src/EEPROM.h:145:20: warning: 'EEPROM' defined but not used [-Wunused-variable]
static EEPROMClass EEPROM;
^~~~~~
Compiling libraries...
Compiling library "HX711_ADC"
"C:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7/bin/avr-g++" -c -g -Os -Wall -Wextra -std=gnu++11 -fpermissive -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -Wno-error=narrowing -MMD -flto -mmcu=atmega328p -DF_CPU=16000000L -DARDUINO=10813 -DARDUINO_AVR_UNO -DARDUINO_ARCH_AVR "-IC:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\cores\arduino" "-IC:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\variants\standard" "-IC:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src" "-IC:\Users\Ewald\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\libraries\EEPROM\src" "C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp" -o "C:\Users\Ewald\AppData\Local\Temp\arduino_build_388271\libraries\HX711_ADC\HX711_ADC.cpp.o"
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp: In member function 'int HX711_ADC::startMultiple(unsigned int)':
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp:99:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(millis() - startMultipleTimeStamp > startMultipleWaitTime) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp: In member function 'int HX711_ADC::startMultiple(unsigned int, bool)':
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp:148:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if(millis() - startMultipleTimeStamp > startMultipleWaitTime) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp: In member function 'void HX711_ADC::setSamplesInUse(int)':
C:\Users\Ewald\Documents\Arduino\libraries\HX711_ADC\src\HX711_ADC.cpp:425:6: warning: unused variable 'old_divbit' [-Wunused-variable]
int old_divbit = divBit;
^~~~~~~~~~

[olkal]

Hi Wolfgang, should be fixed now. Many thanks!

[wollewald]

Thanks!