Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace strings buffer with hasher #2437

Merged
merged 1 commit into from
Feb 21, 2024
Merged

replace strings buffer with hasher #2437

merged 1 commit into from
Feb 21, 2024

Conversation

mxyng
Copy link
Contributor

@mxyng mxyng commented Feb 10, 2024

the buffered value is going into the hasher eventually so write directly to the hasher instead

@mxyng
replace strings buffer with hasher
a1ef2c1 
the buffered value is going into the hasher eventually so write directly
to the hasher instead
@H0llyW00dzZ
Copy link

instead of md5 it would be better if using hash sha256

jmorganca
jmorganca approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jmorganca jmorganca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is much better

@jmorganca
Copy link
Member

@H0llyW00dzZ this is only as an extra verification means with object storage – it is not an alternative to the sha256 verification ollama does when pulling models

@jmorganca jmorganca merged commit 210b652 into main Feb 21, 2024
13 checks passed
@jmorganca jmorganca deleted the mxyng/hash branch February 21, 2024 00:07
jimscard added a commit to jimscard/ollama that referenced this pull request Feb 21, 2024
@jimscard
Merge branch 'main' of https://github.com/jimscard/ollama
0170f57 
* 'main' of https://github.com/jimscard/ollama: (147 commits)
  update llama.cpp submodule to `c14f72d`
  Update big-AGI config file link (ollama#2626)
  add `dist` directory in `build_windows.ps`
  update llama.cpp submodule to `f0d1fafc029a056cd765bdae58dcaa12312e9879`
  better error message when calling `/api/generate` or `/api/chat` with embedding models
  Support for `bert` and `nomic-bert` embedding models
  Update faq.md
  replace strings buffer with hasher (ollama#2437)
  add gguf file types (ollama#2532)
  use http.DefaultClient (ollama#2530)
  update llama.cpp submodule to `66c1968f7` (ollama#2618)
  Add Page Assist to the community integrations (ollama#2447)
  docs: add Msty app in readme (ollama#1775)
  Update README.md to include Elixir LangChain Library (ollama#2180)
  [nit] Remove unused msg local var. (ollama#2511)
  docs: add tenere to terminal clients (ollama#2329)
  Update import.md
  Add ShellOracle to community terminal integrations (ollama#1767)
  Update faq.md
  feat: add Helm Chart link to Package managers list (ollama#1673)
  ...
zhewang1-intc pushed a commit to zhewang1-intc/ollama that referenced this pull request May 13, 2024
@mxyng @zhewang1-intc
replace strings buffer with hasher (ollama#2437)
6ab7f49 
the buffered value is going into the hasher eventually so write directly
to the hasher instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmorganca jmorganca jmorganca approved these changes

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mxyng @H0llyW00dzZ @jmorganca @BruceMacD